The present study was an attempt to investigate the effectiveness of critical literacy approach for developing EFL persuasive writing skills among student teachers at  Faculty of Education. The design of the study was pre - post experimental group. The participants of the study consisted of 30 students of one group and was selected randomly from third year English section student teachers at Faculty of Education. The instruments and materials of the study were: An EFL  persuasive writing skills checklist which was divided into 7 main skills , 25 sub-skills , and  an EFL  persuasive writing test which was designed and validated to be used as  a pre-posttest and a rubric for assessing EFL persuasive writing skills. The  experimental group students were taught by using critical literacy approach program as the new treatment. The implementation of the study was in the second term of the academic year 2021-2022. The researcher applied the test, then the participants taught with the approach, the researcher re-administrated the test to the experimental group. The findings of the study revealed that EFL persuasive writing skills were developed as a result of teaching with critical literacy approach. The findings confirmed the effectiveness of critical Literacy approach for developing EFL persuasive writing skills among student  teachers at  Faculty of Education