Even in the most experienced hands, hypospadias repair in one stage is a challenging issue. The aim of the study was to 
optimize one stage repair for all types of hypospadias and to report on short-and mid-term results. It was done on 112 
patients with different types of hypospadias, their ages was ranged between 2 - 14 years with a mean age of 3.7 years. For distal, mid, and proximal penile types, urethra was reconstructed using Duplay tube, intervening layer from the Dartos fascia. 
For the peno-scrotal type, the urethra was created using onlay island flap from the prepuce and covered by a layer from the tunica vaginalis. Suprapubic and urethral drainage were used in proximal-penile and peno- scrotal varieties while urethral drainage only was used in distal, and mid, penile types. The incidence of fistula formation was as follows: 0% in distal penile, 3.5% in mid-penile, 9% in proximal penile and 17% in peno-scrotal type. Due to low incidence of complications of one stage repair for all types of hypospadias we recommend it, provided selection of the proper technique for the proper anomaly