A total of 243 samples of potato chips (135 samples) and ice cream (108 samples) were collected from different regions and brands in Assiut Governorate - Egypt during May to July, 2011. Iron, manganese, copper, aluminum, nickel, lead, cadmium, selenium and arsenic were determined in samples using atomic absorption spectrophotometer. Results revealed no significant differences (P≤0.01) among regions in most ice cream and potato chips samples. The mean concentration of Lead, cadmium, copper, arsenic (potato chips) and nickel (ice cream) were exceeded than the legal limits established by the Egyptian and Codex standards.