Background: Diabetes is a major public health problem that affects morbidity, fatality and health care resources. Many factors can influence diabetic control. Diabetic control remains the main goal in management of diabetes mellitus and the major therapeutic target for prevention of complications due to diabetes Objective: Is to assess factors affecting glycemic control among type 2 diabetic patients. Patients and Method: a cross sectional study was conducted on 200 diabetics at the Internal Medicine Department, Benha University hospital. A case record form was used including sociodemographic features, anthropometric measurements and metabolic disease profile. Results: Participants were classified according to their glycosylated hemoglobin level into good (7%) and poor (93%) diabetic control. There was a statistically significant association between diabetic control and diabetes duration (p < 0.001), exercise (p = 0.001) (OR (95% CI): 5.59 (1.77-17.62)), body mass index (p < 0.001). There was a statistically significant difference between those with poor and good diabetic control as regard LDL level (OR (95%CI): 50 (6.41-333.3)) (p < 0.001), total cholesterol level (p < 0.001), (median (range): (237 (178-320) and 100 (100-300)) respectively and the mean value of fasting blood sugar ((mean ± SD): 298.52± 55.97 and 170±37.41 respectively, p < 0.001)). Conclusions: Majority of participants had poor diabetic control. Diabetes duration, regular exercise, BMI, LDL and total cholesterol levels significantly affected glycemic control